From: Jędrzej Nowacki Date: Wed, 14 Mar 2012 08:06:32 +0000 (+0100) Subject: Fix a memory leak in QMetaObject::connectSlotsByName function. X-Git-Tag: qt-v5.0.0-alpha1~301 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=439a78974576894b23bce0621e49ce4a593428a9;p=profile%2Fivi%2Fqtbase.git Fix a memory leak in QMetaObject::connectSlotsByName function. QObjectPrivate::Connection time life should be controlled by QMetaObject::Connection handle. Change-Id: Ie7fcd950082a3e6cebc29ecc0622007470914edb Reviewed-by: Olivier Goffart --- diff --git a/src/corelib/kernel/qobject.cpp b/src/corelib/kernel/qobject.cpp index 3a4d1da..b648432 100644 --- a/src/corelib/kernel/qobject.cpp +++ b/src/corelib/kernel/qobject.cpp @@ -3075,7 +3075,7 @@ void QMetaObject::connectSlotsByName(QObject *o) } if (sigIndex < 0) continue; - if (QMetaObjectPrivate::connect(co, sigIndex, o, i)) { + if (Connection(QMetaObjectPrivate::connect(co, sigIndex, o, i))) { foundIt = true; break; }