From: Karol Lewandowski <k.lewandowsk@samsung.com>
Date: Thu, 21 May 2020 10:48:30 +0000 (+0200)
Subject: Clarify logs related to coredump handling
X-Git-Tag: accepted/tizen/unified/20200602.133237~4
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=437dfed641c3199deede83e94618f9e9d55e7836;p=platform%2Fcore%2Fsystem%2Fcrash-worker.git

Clarify logs related to coredump handling

The coredump should not be created when minicoredumper (-s) works
correctly.  Make this clear in code and logs.

Change-Id: I2e4e160a46ac4be25143f310ffc336b121530cc8
---

diff --git a/src/crash-manager/crash-manager.c b/src/crash-manager/crash-manager.c
index 42044be..bb01ee2 100644
--- a/src/crash-manager/crash-manager.c
+++ b/src/crash-manager/crash-manager.c
@@ -702,12 +702,9 @@ static bool execute_minicoredump(struct crash_info *cinfo, int *exit_code)
 	/* Minicoredumper must be executed to dump at least PRSTATUS for
 	   other tools, coredump, however, might have been disabled. */
 	if (!config.dump_core && file_exists_in_dir(cinfo->pfx, coredump_name)) {
+		_E("Saving core disabled but coredump found (minicoredumper bug?). Removing coredump %s/%s", cinfo->pfx, coredump_name);
 		if (!remove_file_in_dir(cinfo->pfx, coredump_name))
-			_E("Saving core disabled - removing coredump %s/%s failed: %m",
-			   cinfo->pfx, coredump_name);
-		else
-			_D("Saving core disabled - removed coredump %s/%s",
-			   cinfo->pfx, coredump_name);
+			_E("Removing coredump %s/%s failed: %m", cinfo->pfx, coredump_name);
 	}
 
 out: