From: Jakub Kicinski Date: Tue, 24 Jan 2023 03:52:31 +0000 (-0800) Subject: devlink: remove a dubious assumption in fmsg dumping X-Git-Tag: v6.6.7~3490^2~212 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4373a023e0388fc19e27d37f61401bce6ff4c9d7;p=platform%2Fkernel%2Flinux-starfive.git devlink: remove a dubious assumption in fmsg dumping Build bot detects that err may be returned uninitialized in devlink_fmsg_prepare_skb(). This is not really true because all fmsgs users should create at least one outer nest, and therefore fmsg can't be completely empty. That said the assumption is not trivial to confirm, so let's follow the bots advice, anyway. This code does not seem to have changed since its inception in commit 1db64e8733f6 ("devlink: Add devlink formatted message (fmsg) API") Reviewed-by: Jiri Pirko Link: https://lore.kernel.org/r/20230124035231.787381-1-kuba@kernel.org Signed-off-by: Jakub Kicinski --- diff --git a/net/devlink/leftover.c b/net/devlink/leftover.c index 8eab95c..7462128 100644 --- a/net/devlink/leftover.c +++ b/net/devlink/leftover.c @@ -7116,8 +7116,8 @@ devlink_fmsg_prepare_skb(struct devlink_fmsg *fmsg, struct sk_buff *skb, { struct devlink_fmsg_item *item; struct nlattr *fmsg_nlattr; + int err = 0; int i = 0; - int err; fmsg_nlattr = nla_nest_start_noflag(skb, DEVLINK_ATTR_FMSG); if (!fmsg_nlattr)