From: Dan Carpenter Date: Tue, 9 Oct 2012 23:42:18 +0000 (+0000) Subject: isdn: fix a wrapping bug in isdn_ppp_ioctl() X-Git-Tag: v3.7-rc1~25^2~16 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=435f08a721919a0027ff4f39f0b51c141c0e2c29;p=profile%2Fivi%2Fkernel-x86-ivi.git isdn: fix a wrapping bug in isdn_ppp_ioctl() "protos" is an array of unsigned longs and "i" is the number of bits in an unsigned long so we need to use 1UL as well to prevent the shift from wrapping around. Signed-off-by: Dan Carpenter Signed-off-by: David S. Miller --- diff --git a/drivers/isdn/i4l/isdn_ppp.c b/drivers/isdn/i4l/isdn_ppp.c index a1e7601..61d78fa 100644 --- a/drivers/isdn/i4l/isdn_ppp.c +++ b/drivers/isdn/i4l/isdn_ppp.c @@ -595,7 +595,7 @@ isdn_ppp_ioctl(int min, struct file *file, unsigned int cmd, unsigned long arg) j = ipc->num / (sizeof(long) * 8); i = ipc->num % (sizeof(long) * 8); if (j < 8) - protos[j] |= (0x1 << i); + protos[j] |= (1UL << i); ipc = ipc->next; } if ((r = set_arg(argp, protos, 8 * sizeof(long))))