From: Viresh Kumar Date: Thu, 13 Aug 2015 05:10:28 +0000 (+0530) Subject: greybus: connection: Don't free resources freed by gb_connection_release() X-Git-Tag: v4.14-rc1~2366^2~378^2~21^2~1276 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=435ea76218c9f3257990c6da8b37bf7708598f49;p=platform%2Fkernel%2Flinux-rpi.git greybus: connection: Don't free resources freed by gb_connection_release() We are already doing put_device() here and so don't need to free resources directly, except ida. Fixes: afde17fe0b61 ("greybus/connection: fix jump label on device_add failure") Signed-off-by: Viresh Kumar Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c index d0f499d..7eb2868 100644 --- a/drivers/staging/greybus/connection.c +++ b/drivers/staging/greybus/connection.c @@ -270,7 +270,7 @@ gb_connection_create_range(struct greybus_host_device *hd, pr_err("failed to add connection device for cport 0x%04hx\n", cport_id); - goto err_free_kfifo; + goto err_remove_ida; } spin_lock_irq(&gb_connections_lock); @@ -296,8 +296,6 @@ gb_connection_create_range(struct greybus_host_device *hd, return connection; -err_free_kfifo: - kfifo_free(&connection->ts_kfifo); err_destroy_wq: destroy_workqueue(connection->wq); err_free_connection: