From: Tanner Gooding <tagoo@outlook.com>
Date: Wed, 28 Nov 2018 11:54:12 +0000 (-0800)
Subject: Fixing up Utf8Parser.TryParseNumber to not fail for overly large exponents (dotnet... 
X-Git-Tag: submit/tizen/20210909.063632~11030^2~3234
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=43346db9112e1e52cbee0113b3108648b8cb22a5;p=platform%2Fupstream%2Fdotnet%2Fruntime.git

Fixing up Utf8Parser.TryParseNumber to not fail for overly large exponents (dotnet/coreclr#21233)



Commit migrated from https://github.com/dotnet/coreclr/commit/e91cbf40efb743a859646e841ea168599dbd957e
---

diff --git a/src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Utf8Parser/Utf8Parser.Number.cs b/src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Utf8Parser/Utf8Parser.Number.cs
index daa1da6..799a3fe 100644
--- a/src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Utf8Parser/Utf8Parser.Number.cs
+++ b/src/libraries/System.Private.CoreLib/src/System/Buffers/Text/Utf8Parser/Utf8Parser.Number.cs
@@ -303,10 +303,15 @@ namespace System.Buffers.Text
             {
                 if (number.Scale > int.MaxValue - (long)absoluteExponent)
                 {
-                    bytesConsumed = 0;
-                    return false;
+                    // A scale overflow means all non-zero digits are all so far to the right of the decimal point, no
+                    // number format we have will be able to see them. Just pin the scale at the absolute maximum 
+                    // and let the converter produce a 0 with the max precision available for that type.
+                    number.Scale = int.MaxValue;
+                }
+                else
+                {
+                    number.Scale += (int)absoluteExponent;
                 }
-                number.Scale += (int)absoluteExponent;
             }
 
             digits[dstIndex] = 0;