From: K. Y. Srinivasan Date: Mon, 26 Aug 2013 21:08:58 +0000 (-0700) Subject: Drivers: hv: vmbus: Fix a bug in the handling of channel offers X-Git-Tag: v3.12-rc1~185^2~9 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=42dceebe34600b2d02a38baa3e869009ba3d14c7;p=profile%2Fivi%2Fkernel-x86-ivi.git Drivers: hv: vmbus: Fix a bug in the handling of channel offers The channel state should be correctly set before registering the device. In the current code the driver probe would fail for channels that have been rescinded and subsequently re-offered. Fix the bug. Signed-off-by: K. Y. Srinivasan Cc: stable # 3.11 Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/hv/channel_mgmt.c b/drivers/hv/channel_mgmt.c index 12ec8c8..bbff5f2 100644 --- a/drivers/hv/channel_mgmt.c +++ b/drivers/hv/channel_mgmt.c @@ -293,6 +293,13 @@ static void vmbus_process_offer(struct work_struct *work) } /* + * This state is used to indicate a successful open + * so that when we do close the channel normally, we + * can cleanup properly + */ + newchannel->state = CHANNEL_OPEN_STATE; + + /* * Start the process of binding this offer to the driver * We need to set the DeviceObject field before calling * vmbus_child_dev_add() @@ -318,13 +325,6 @@ static void vmbus_process_offer(struct work_struct *work) kfree(newchannel->device_obj); free_channel(newchannel); - } else { - /* - * This state is used to indicate a successful open - * so that when we do close the channel normally, we - * can cleanup properly - */ - newchannel->state = CHANNEL_OPEN_STATE; } }