From: Richard Sandiford Date: Thu, 28 Aug 2014 06:22:56 +0000 (+0000) Subject: df-problems.c: Include rtl-iter.h. X-Git-Tag: upstream/12.2.0~60738 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=42be54562a66daa12a5958897d5869d7ba0dd52c;p=platform%2Fupstream%2Fgcc.git df-problems.c: Include rtl-iter.h. gcc/ * df-problems.c: Include rtl-iter.h. (find_memory): Turn from being a for_each_rtx callback to being a function that examines each subrtx itself. Continue to look for volatile references even after a nonvolatile one has been found. (can_move_insns_across): Update calls accordingly. From-SVN: r214634 --- diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 5ca9fb6..320b9fc 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,13 @@ 2014-08-28 Richard Sandiford + * df-problems.c: Include rtl-iter.h. + (find_memory): Turn from being a for_each_rtx callback to being + a function that examines each subrtx itself. Continue to look for + volatile references even after a nonvolatile one has been found. + (can_move_insns_across): Update calls accordingly. + +2014-08-28 Richard Sandiford + * ddg.c (walk_mems_2, walk_mems_1): Delete. (insns_may_alias_p): Use FOR_EACH_SUBRTX rather than for_each_rtx to iterate over subrtxes. Return a bool rather than an int. diff --git a/gcc/df-problems.c b/gcc/df-problems.c index 34b4f7e..bf8800f 100644 --- a/gcc/df-problems.c +++ b/gcc/df-problems.c @@ -44,6 +44,7 @@ along with GCC; see the file COPYING3. If not see #include "dce.h" #include "valtrack.h" #include "dumpfile.h" +#include "rtl-iter.h" /* Note that turning REG_DEAD_DEBUGGING on will cause gcc.c-torture/unsorted/dump-noaddr.c to fail because it prints @@ -3584,25 +3585,27 @@ df_simulate_one_insn_forwards (basic_block bb, rtx_insn *insn, bitmap live) #define MEMREF_NORMAL 1 #define MEMREF_VOLATILE 2 -/* A subroutine of can_move_insns_across_p called through for_each_rtx. - Return either MEMREF_NORMAL or MEMREF_VOLATILE if a memory is found. */ +/* Return an OR of MEMREF_NORMAL or MEMREF_VOLATILE for the MEMs in X. */ static int -find_memory (rtx *px, void *data ATTRIBUTE_UNUSED) +find_memory (rtx insn) { - rtx x = *px; - - if (GET_CODE (x) == ASM_OPERANDS && MEM_VOLATILE_P (x)) - return MEMREF_VOLATILE; - - if (!MEM_P (x)) - return 0; - if (MEM_VOLATILE_P (x)) - return MEMREF_VOLATILE; - if (MEM_READONLY_P (x)) - return 0; - - return MEMREF_NORMAL; + int flags = 0; + subrtx_iterator::array_type array; + FOR_EACH_SUBRTX (iter, array, PATTERN (insn), NONCONST) + { + const_rtx x = *iter; + if (GET_CODE (x) == ASM_OPERANDS && MEM_VOLATILE_P (x)) + flags |= MEMREF_VOLATILE; + else if (MEM_P (x)) + { + if (MEM_VOLATILE_P (x)) + flags |= MEMREF_VOLATILE; + else if (!MEM_READONLY_P (x)) + flags |= MEMREF_NORMAL; + } + } + return flags; } /* A subroutine of can_move_insns_across_p called through note_stores. @@ -3706,8 +3709,7 @@ can_move_insns_across (rtx_insn *from, rtx_insn *to, { if (volatile_insn_p (PATTERN (insn))) return false; - memrefs_in_across |= for_each_rtx (&PATTERN (insn), find_memory, - NULL); + memrefs_in_across |= find_memory (insn); note_stores (PATTERN (insn), find_memory_stores, &mem_sets_in_across); /* This is used just to find sets of the stack pointer. */ @@ -3789,8 +3791,7 @@ can_move_insns_across (rtx_insn *from, rtx_insn *to, int mem_ref_flags = 0; int mem_set_flags = 0; note_stores (PATTERN (insn), find_memory_stores, &mem_set_flags); - mem_ref_flags = for_each_rtx (&PATTERN (insn), find_memory, - NULL); + mem_ref_flags = find_memory (insn); /* Catch sets of the stack pointer. */ mem_ref_flags |= mem_set_flags;