From: Takashi Iwai <tiwai@suse.de>
Date: Tue, 8 Jun 2021 14:04:55 +0000 (+0200)
Subject: ALSA: bt87x: Fix assignment in if condition
X-Git-Tag: accepted/tizen/unified/20230118.172025~6918^2~9^2~153
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=429731d3080e13caabaceebc41dac3d759350bbb;p=platform%2Fkernel%2Flinux-rpi.git

ALSA: bt87x: Fix assignment in if condition

PCI BT87x driver code contains an assignments in if condition, which
is a bad coding style that may confuse readers and occasionally lead
to bugs.

This patch is merely for coding-style fixes, no functional changes.

Link: https://lore.kernel.org/r/20210608140540.17885-22-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/pci/bt87x.c b/sound/pci/bt87x.c
index 91512b3..39bcfb8 100644
--- a/sound/pci/bt87x.c
+++ b/sound/pci/bt87x.c
@@ -719,7 +719,8 @@ static int snd_bt87x_create(struct snd_card *card,
 	chip->irq = -1;
 	spin_lock_init(&chip->reg_lock);
 
-	if ((err = pci_request_regions(pci, "Bt87x audio")) < 0) {
+	err = pci_request_regions(pci, "Bt87x audio");
+	if (err < 0) {
 		kfree(chip);
 		pci_disable_device(pci);
 		return err;