From: Tim-Philipp Müller Date: Wed, 12 Apr 2017 08:58:49 +0000 (+0100) Subject: No need for newlines in debug log statements X-Git-Tag: 1.19.3~511^2~2278 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4246198fb3d67b5651700613b7b2b653a25fa3bb;p=platform%2Fupstream%2Fgstreamer.git No need for newlines in debug log statements --- diff --git a/ext/theora/gsttheoraparse.c b/ext/theora/gsttheoraparse.c index f55419b..b6f8a50 100644 --- a/ext/theora/gsttheoraparse.c +++ b/ext/theora/gsttheoraparse.c @@ -324,7 +324,7 @@ theora_parse_set_streamheader (GstTheoraParse * parse) ret = th_decode_headerin (&parse->info, &parse->comment, &setup, &packet); gst_buffer_unmap (buf, &map); if (ret < 0) { - GST_WARNING_OBJECT (parse, "Failed to decode Theora header %d: %d\n", + GST_WARNING_OBJECT (parse, "Failed to decode Theora header %d: %d", i + 1, ret); } } diff --git a/gst-libs/gst/pbutils/encoding-profile.c b/gst-libs/gst/pbutils/encoding-profile.c index 9f12137..719ec9c 100644 --- a/gst-libs/gst/pbutils/encoding-profile.c +++ b/gst-libs/gst/pbutils/encoding-profile.c @@ -1633,7 +1633,7 @@ create_encoding_stream_profile (gchar * serialized_profile) presence = g_ascii_strtoll (strpresence_v[1], &endptr, 10); if (endptr == strpresence_v[1]) { - GST_ERROR ("Wrong presence %s\n", strpresence_v[1]); + GST_ERROR ("Wrong presence %s", strpresence_v[1]); return NULL; } @@ -1836,7 +1836,7 @@ add_stream_to_profile (GstEncodingContainerProfile * profile, gst_structure_remove_field (s, "alignment"); } - GST_LOG ("Stream: %" GST_PTR_FORMAT "\n", caps); + GST_LOG ("Stream: %" GST_PTR_FORMAT, caps); if (GST_IS_DISCOVERER_AUDIO_INFO (sinfo)) { sprofile = (GstEncodingProfile *) gst_encoding_audio_profile_new (caps, NULL, @@ -1903,7 +1903,7 @@ gst_encoding_profile_from_discoverer (GstDiscovererInfo * info) return NULL; caps = gst_discoverer_stream_info_get_caps (sinfo); - GST_LOG ("Container: %" GST_PTR_FORMAT "\n", caps); + GST_LOG ("Container: %" GST_PTR_FORMAT, caps); profile = gst_encoding_container_profile_new ("auto-generated", "Automatically generated from GstDiscovererInfo", caps, NULL); diff --git a/gst-libs/gst/sdp/gstsdpmessage.c b/gst-libs/gst/sdp/gstsdpmessage.c index 11d86a0..a3fb942 100644 --- a/gst-libs/gst/sdp/gstsdpmessage.c +++ b/gst-libs/gst/sdp/gstsdpmessage.c @@ -3785,7 +3785,7 @@ gst_sdp_media_set_media_from_caps (const GstCaps * caps, GstSDPMedia * media) tmp = g_strdup_printf ("%d nack", caps_pt); gst_sdp_media_add_attribute (media, "rtcp-fb", tmp); g_free (tmp); - GST_DEBUG ("adding rtcp-fb-nack to pt=%d\n", caps_pt); + GST_DEBUG ("adding rtcp-fb-nack to pt=%d", caps_pt); } } @@ -3794,7 +3794,7 @@ gst_sdp_media_set_media_from_caps (const GstCaps * caps, GstSDPMedia * media) tmp = g_strdup_printf ("%d nack pli", caps_pt); gst_sdp_media_add_attribute (media, "rtcp-fb", tmp); g_free (tmp); - GST_DEBUG ("adding rtcp-fb-nack-pli to pt=%d\n", caps_pt); + GST_DEBUG ("adding rtcp-fb-nack-pli to pt=%d", caps_pt); } } @@ -3803,7 +3803,7 @@ gst_sdp_media_set_media_from_caps (const GstCaps * caps, GstSDPMedia * media) tmp = g_strdup_printf ("%d ccm fir", caps_pt); gst_sdp_media_add_attribute (media, "rtcp-fb", tmp); g_free (tmp); - GST_DEBUG ("adding rtcp-fb-ccm-fir to pt=%d\n", caps_pt); + GST_DEBUG ("adding rtcp-fb-ccm-fir to pt=%d", caps_pt); } } diff --git a/gst-libs/gst/tag/id3v2frames.c b/gst-libs/gst/tag/id3v2frames.c index 58a3bf6..8e9f782 100644 --- a/gst-libs/gst/tag/id3v2frames.c +++ b/gst-libs/gst/tag/id3v2frames.c @@ -1043,7 +1043,7 @@ string_utf8_dup (const gchar * start, const guint size) if ((utf8 = g_convert (start, size, "UTF-8", *c, &bytes_read, NULL, NULL))) { if (bytes_read == size) { - GST_DEBUG ("Using charset %s to interperate id3 tags\n", *c); + GST_DEBUG ("Using charset %s to interpret id3 tags", *c); g_strfreev (csets); goto beach; } diff --git a/gst/typefind/gsttypefindfunctions.c b/gst/typefind/gsttypefindfunctions.c index 9ad6667..25c8645 100644 --- a/gst/typefind/gsttypefindfunctions.c +++ b/gst/typefind/gsttypefindfunctions.c @@ -2385,7 +2385,7 @@ suggest: if (data0 != first_sync && prob >= 10) prob -= 10; - GST_LOG ("Suggesting MPEG %d system stream, %d packs, %d pes, prob %u%%\n", + GST_LOG ("Suggesting MPEG %d system stream, %d packs, %d pes, prob %u%%", mpegversion, pack_headers, pes_headers, prob); gst_type_find_suggest_simple (tf, prob, "video/mpeg", diff --git a/tests/check/libs/tag.c b/tests/check/libs/tag.c index 3caaa94..c97395b 100644 --- a/tests/check/libs/tag.c +++ b/tests/check/libs/tag.c @@ -856,7 +856,7 @@ GST_START_TEST (test_language_utils) ASSERT_STRINGS_EQUAL (gst_tag_get_language_code_iso_639_1 (c2t), *c); ASSERT_STRINGS_EQUAL (gst_tag_get_language_code_iso_639_1 (c2b), *c); - GST_DEBUG ("[%s] %s %s %s : %s\n", *c, c1, c2t, c2b, lang_name); + GST_DEBUG ("[%s] %s %s %s : %s", *c, c1, c2t, c2b, lang_name); } g_strfreev (lang_codes); diff --git a/tests/icles/test-reverseplay.c b/tests/icles/test-reverseplay.c index e562a04..7469329 100644 --- a/tests/icles/test-reverseplay.c +++ b/tests/icles/test-reverseplay.c @@ -210,7 +210,7 @@ handle_output (GstPad * pad, GstPadProbeInfo * info, StreamInfo * si) GstClockTime start, end; GstBuffer *buf; - GST_LOG_OBJECT (pad, "Fired probe type 0x%x\n", info->type); + GST_LOG_OBJECT (pad, "Fired probe type 0x%x", info->type); if (info->type & GST_PAD_PROBE_TYPE_BUFFER_LIST) { g_warning ("Buffer list handling not implemented");