From: Oliver Endriss <o.endriss@gmx.de>
Date: Fri, 3 Nov 2006 18:13:52 +0000 (-0300)
Subject: V4L/DVB (4917): Saa7146: Convert SAA7146_IER_{DIS,EN}ABLE macros to inline functions
X-Git-Tag: v3.12-rc1~32223^2~18^2~35
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4207700d9b238c2db1bcba47a23251c6024687b6;p=kernel%2Fkernel-generic.git

V4L/DVB (4917): Saa7146: Convert SAA7146_IER_{DIS,EN}ABLE macros to inline functions

Convert SAA7146_IER_{DIS,EN}ABLE macros to inline functions.
Fixes a problem with macro expansion (reported by C.Y.M).

Signed-off-by: Oliver Endriss <o.endriss@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@infradead.org>
---

diff --git a/include/media/saa7146.h b/include/media/saa7146.h
index afa5ff6..796bcf1 100644
--- a/include/media/saa7146.h
+++ b/include/media/saa7146.h
@@ -42,20 +42,6 @@ extern unsigned int saa7146_debug;
 #define DEB_INT(x)  if (0!=(DEBUG_VARIABLE&0x20)) { DEBUG_PROLOG; printk x; } /* interrupt debug messages */
 #define DEB_CAP(x)  if (0!=(DEBUG_VARIABLE&0x40)) { DEBUG_PROLOG; printk x; } /* capture debug messages */
 
-#define SAA7146_IER_DISABLE(x,y) 					\
-	do { 								\
-		unsigned int flags; 					\
-		spin_lock_irqsave(&x->int_slock, flags); 		\
-		saa7146_write(x, IER, saa7146_read(x, IER) & ~(y));	\
-		spin_unlock_irqrestore(&x->int_slock, flags);		\
-	} while(0)
-#define SAA7146_IER_ENABLE(x,y)						\
-	do { 								\
-		unsigned int flags; 					\
-		spin_lock_irqsave(&x->int_slock, flags); 		\
-		saa7146_write(x, IER, saa7146_read(x, IER) | (y));	\
-		spin_unlock_irqrestore(&x->int_slock, flags);		\
-	} while(0)
 #define SAA7146_ISR_CLEAR(x,y) \
 	saa7146_write(x, ISR, (y));
 
@@ -451,4 +437,20 @@ int saa7146_wait_for_debi_done(struct saa7146_dev *dev, int nobusyloop);
 #define SAA7146_I2C_BUS_BIT_RATE_80	(0x200)
 #define SAA7146_I2C_BUS_BIT_RATE_60	(0x300)
 
+static inline void SAA7146_IER_DISABLE(struct saa7146_dev *x, unsigned y)
+{
+	unsigned long flags;
+	spin_lock_irqsave(&x->int_slock, flags);
+	saa7146_write(x, IER, saa7146_read(x, IER) & ~y);
+	spin_unlock_irqrestore(&x->int_slock, flags);
+}
+
+static inline void SAA7146_IER_ENABLE(struct saa7146_dev *x, unsigned y)
+{
+	unsigned long flags;
+	spin_lock_irqsave(&x->int_slock, flags);
+	saa7146_write(x, IER, saa7146_read(x, IER) | y);
+	spin_unlock_irqrestore(&x->int_slock, flags);
+}
+
 #endif