From: Aditya Pakki <pakki001@umn.edu>
Date: Wed, 20 Mar 2019 15:27:11 +0000 (-0500)
Subject: usb: usb251xb: fix to avoid potential NULL pointer dereference
X-Git-Tag: v5.15~6680^2~5
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=41f00e6e9e55546390031996b773e7f3c1d95928;p=platform%2Fkernel%2Flinux-starfive.git

usb: usb251xb: fix to avoid potential NULL pointer dereference

of_match_device in usb251xb_probe can fail and returns a NULL pointer.
The patch avoids a potential NULL pointer dereference in this scenario.

Signed-off-by: Aditya Pakki <pakki001@umn.edu>
Reviewed-by: Richard Leitner <richard.leitner@skidata.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/misc/usb251xb.c b/drivers/usb/misc/usb251xb.c
index 2c8e2ca..0468484 100644
--- a/drivers/usb/misc/usb251xb.c
+++ b/drivers/usb/misc/usb251xb.c
@@ -612,7 +612,7 @@ static int usb251xb_probe(struct usb251xb *hub)
 							   dev);
 	int err;
 
-	if (np) {
+	if (np && of_id) {
 		err = usb251xb_get_ofdata(hub,
 					  (struct usb251xb_data *)of_id->data);
 		if (err) {