From: Timothy Arceri Date: Sat, 14 Nov 2015 03:05:30 +0000 (+1100) Subject: glsl: call set_shader_inout_layout() earlier X-Git-Tag: upstream/17.1.0~14394 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4196af4ce7cdb0217a7cc6e196b1a788d32c5b6f;p=platform%2Fupstream%2Fmesa.git glsl: call set_shader_inout_layout() earlier This will allow us to add error checking to this function in a later patch, if we don't move it the error messages will go missing. Reviewed-by: Emil Velikov --- diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp index c54dcfd..13a3c94 100644 --- a/src/glsl/glsl_parser_extras.cpp +++ b/src/glsl/glsl_parser_extras.cpp @@ -1799,6 +1799,9 @@ _mesa_glsl_compile_shader(struct gl_context *ctx, struct gl_shader *shader, if (shader->InfoLog) ralloc_free(shader->InfoLog); + if (!state->error) + set_shader_inout_layout(shader, state); + shader->symbols = new(shader->ir) glsl_symbol_table; shader->CompileStatus = !state->error; shader->InfoLog = state->info_log; @@ -1806,9 +1809,6 @@ _mesa_glsl_compile_shader(struct gl_context *ctx, struct gl_shader *shader, shader->IsES = state->es_shader; shader->uses_builtin_functions = state->uses_builtin_functions; - if (!state->error) - set_shader_inout_layout(shader, state); - /* Retain any live IR, but trash the rest. */ reparent_ir(shader->ir, shader->ir);