From: Mike Klein Date: Wed, 22 Feb 2017 18:00:33 +0000 (-0500) Subject: Switch SkTaskGroup to std::atomic. X-Git-Tag: accepted/tizen/5.0/unified/20181102.025319~55^2~145 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=416bbd97cee9e221577c729a8072fdb2057cbdf8;p=platform%2Fupstream%2FlibSkiaSharp.git Switch SkTaskGroup to std::atomic. No interesting change, just getting on std APIs. Change-Id: I0f42cbb6854b49a6ae8266e5b92f977d27f4e032 Reviewed-on: https://skia-review.googlesource.com/8860 Reviewed-by: Herb Derby Commit-Queue: Mike Klein --- diff --git a/src/core/SkTaskGroup.cpp b/src/core/SkTaskGroup.cpp index 78ab71c..9469b8c 100644 --- a/src/core/SkTaskGroup.cpp +++ b/src/core/SkTaskGroup.cpp @@ -11,20 +11,20 @@ SkTaskGroup::SkTaskGroup(SkExecutor& executor) : fPending(0), fExecutor(executor) {} void SkTaskGroup::add(std::function fn) { - fPending.fetch_add(+1, sk_memory_order_relaxed); + fPending.fetch_add(+1, std::memory_order_relaxed); fExecutor.add([=] { fn(); - fPending.fetch_add(-1, sk_memory_order_release); + fPending.fetch_add(-1, std::memory_order_release); }); } void SkTaskGroup::batch(int N, std::function fn) { // TODO: I really thought we had some sort of more clever chunking logic. - fPending.fetch_add(+N, sk_memory_order_relaxed); + fPending.fetch_add(+N, std::memory_order_relaxed); for (int i = 0; i < N; i++) { fExecutor.add([=] { fn(i); - fPending.fetch_add(-1, sk_memory_order_release); + fPending.fetch_add(-1, std::memory_order_release); }); } } @@ -34,7 +34,7 @@ void SkTaskGroup::wait() { // This lets SkTaskGroups nest arbitrarily deep on a single SkExecutor: // no thread ever blocks waiting for others to do its work. // (We may end up doing work that's not part of our task group. That's fine.) - while (fPending.load(sk_memory_order_acquire) > 0) { + while (fPending.load(std::memory_order_acquire) > 0) { fExecutor.borrow(); } } diff --git a/src/core/SkTaskGroup.h b/src/core/SkTaskGroup.h index cba9eea..ff291ea 100644 --- a/src/core/SkTaskGroup.h +++ b/src/core/SkTaskGroup.h @@ -8,9 +8,9 @@ #ifndef SkTaskGroup_DEFINED #define SkTaskGroup_DEFINED -#include "SkAtomics.h" #include "SkExecutor.h" #include "SkTypes.h" +#include #include class SkTaskGroup : SkNoncopyable { @@ -37,8 +37,8 @@ public: }; private: - SkAtomic fPending; - SkExecutor& fExecutor; + std::atomic fPending; + SkExecutor& fExecutor; }; #endif//SkTaskGroup_DEFINED