From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Date: Thu, 19 Dec 2019 20:19:29 +0000 (-0500)
Subject: autoconvert: Fix lock-less exchange or free condition
X-Git-Tag: 1.19.3~507^2~2519
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=416728f21393b98acd4a13082a20de24c6a1fec0;p=platform%2Fupstream%2Fgstreamer.git

autoconvert: Fix lock-less exchange or free condition

Before this change, we would free the list we just have saved.

Fixes #1158
---

diff --git a/gst/autoconvert/gstautoconvert.c b/gst/autoconvert/gstautoconvert.c
index 46bec13..7bf7cac 100644
--- a/gst/autoconvert/gstautoconvert.c
+++ b/gst/autoconvert/gstautoconvert.c
@@ -895,7 +895,7 @@ gst_auto_convert_load_factories (GstAutoConvert * autoconvert)
 
   g_assert (all_factories);
 
-  if (g_atomic_pointer_compare_and_exchange (&autoconvert->factories, NULL,
+  if (!g_atomic_pointer_compare_and_exchange (&autoconvert->factories, NULL,
           all_factories)) {
     gst_plugin_feature_list_free (all_factories);
   }