From: Bowon Ryu <bowon.ryu@samsung.com>
Date: Fri, 4 Aug 2023 10:01:36 +0000 (+0900)
Subject: Add logs and clean code for clipboard
X-Git-Tag: dali_2.2.39~7^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=414b44fec737663d6e45f8d56311958e589fc6f8;p=platform%2Fcore%2Fuifw%2Fdali-adaptor.git

Add logs and clean code for clipboard

Currently, clipboard is still under development
and needs to match the behavior with efl and new cbhm.
Adds a rather detailed log for smooth development.

Some logs may be removed when development is stable.

Change-Id: I2abe8ee4441f06d73ade661ee71aa30d00f2fa19
Signed-off-by: Bowon Ryu <bowon.ryu@samsung.com>
---

diff --git a/dali/internal/clipboard/tizen-wayland/clipboard-impl-ecore-wl.cpp b/dali/internal/clipboard/tizen-wayland/clipboard-impl-ecore-wl.cpp
index 65e89d1..9e84a99 100644
--- a/dali/internal/clipboard/tizen-wayland/clipboard-impl-ecore-wl.cpp
+++ b/dali/internal/clipboard/tizen-wayland/clipboard-impl-ecore-wl.cpp
@@ -72,52 +72,54 @@ struct Clipboard::Impl
   uint32_t GetData(const std::string &mimeType)
   {
     const char* type = mimeType.c_str();
-    if(type)
+    if(!type)
     {
-      Ecore_Wl2_Display* display = ecore_wl2_connected_display_get(NULL);
-      Ecore_Wl2_Input*   input   = ecore_wl2_input_default_input_get(display);
-      Ecore_Wl2_Offer*   offer   = ecore_wl2_dnd_selection_get(input);
+      DALI_LOG_ERROR("no request type, type is null.\n");
+      return 0u;
+    }
+
+    Ecore_Wl2_Display* display = ecore_wl2_connected_display_get(NULL);
+    Ecore_Wl2_Input*   input   = ecore_wl2_input_default_input_get(display);
+    Ecore_Wl2_Offer*   offer   = ecore_wl2_dnd_selection_get(input);
+
+    if(!offer)
+    {
+      DALI_LOG_ERROR("selection_get fail, request type:%s\n", mimeType.c_str());
+      return 0u;
+    }
 
-      if(!offer)
+    Eina_Array*  availableTypes = ecore_wl2_offer_mimes_get(offer);
+    char*        selectedType   = nullptr;
+    unsigned int typeCount      = (unsigned int)eina_array_count((Eina_Array *)availableTypes);
+
+    for(unsigned int i = 0; i < typeCount && !selectedType; ++i)
+    {
+      char* availableType = (char*)eina_array_data_get((Eina_Array *)availableTypes, i);
+      if(!mimeType.compare(availableType))
       {
-        DALI_LOG_ERROR("selection_get fail, request type:%s\n", mimeType.c_str());
-        return 0u;
+        selectedType = availableType;
+        break;
       }
-      else
-      {
-        Eina_Array* availableTypes = ecore_wl2_offer_mimes_get(offer);
-        char*       selectedType = nullptr;
-
-        for(unsigned int i = 0; i < (unsigned int)eina_array_count((Eina_Array *)availableTypes) && !selectedType; ++i)
-        {
-          char* availableType = (char*)eina_array_data_get((Eina_Array *)availableTypes, i);
-          if(!mimeType.compare(availableType))
-          {
-            selectedType = availableType;
-            break;
-          }
-        }
+    }
 
-        if(selectedType)
-        {
-          mDataId++;
-          mDataRequestIds.push_back(mDataId);
-          mDataRequestItems[mDataId] = std::make_pair(mimeType, offer);
-          ecore_wl2_offer_receive(offer, const_cast<char*>(type));
-          ecore_wl2_display_flush(ecore_wl2_input_display_get(input));
-          DALI_LOG_RELEASE_INFO("offer_receive, id:%u, request type:%s\n", mDataId, mimeType.c_str());
-          return mDataId;
-        }
-        else
-        {
-          DALI_LOG_ERROR("no matching type, request type:%s\n", mimeType.c_str());
-          return 0u;
-        }
+    if(!selectedType)
+    {
+      DALI_LOG_ERROR("no matching type, num of available types:%u, request type:%s\n", typeCount, mimeType.c_str());
+      for(unsigned int i = 0; i < typeCount && !selectedType; ++i)
+      {
+        DALI_LOG_ERROR("available type[%u]:%s\n", i, (char*)eina_array_data_get((Eina_Array *)availableTypes, i));
       }
+      return 0u;
     }
 
-    DALI_LOG_ERROR("no request type, type is null.\n");
-    return 0u;
+    mDataId++;
+    mDataRequestIds.push_back(mDataId);
+    mDataRequestItems[mDataId] = std::make_pair(mimeType, offer);
+
+    ecore_wl2_offer_receive(offer, const_cast<char*>(type));
+    ecore_wl2_display_flush(ecore_wl2_input_display_get(input));
+    DALI_LOG_RELEASE_INFO("offer_receive, id:%u, request type:%s\n", mDataId, mimeType.c_str());
+    return mDataId;
   }
 
   void SendData(void* event)