From: Benjamin Otte <otte@redhat.com>
Date: Sun, 12 Oct 2014 00:21:08 +0000 (+0200)
Subject: gfile: g_file_equal (x, x) is TRUE
X-Git-Tag: 2.43.0~4
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4125415e7f4d1213fc7122beac0d91af08e37b28;p=platform%2Fupstream%2Fglib.git

gfile: g_file_equal (x, x) is TRUE

So shortcut it.

I wrote this patch less as a performance optimization and more as a
clarification, so that people looking at the code can be assured of this
invariant.

https://bugzilla.gnome.org/show_bug.cgi?id=738374
---

diff --git a/gio/gfile.c b/gio/gfile.c
index 0facca1..2e1e3cb 100644
--- a/gio/gfile.c
+++ b/gio/gfile.c
@@ -660,6 +660,9 @@ g_file_equal (GFile *file1,
   g_return_val_if_fail (G_IS_FILE (file1), FALSE);
   g_return_val_if_fail (G_IS_FILE (file2), FALSE);
 
+  if (file1 == file2)
+    return TRUE;
+
   if (G_TYPE_FROM_INSTANCE (file1) != G_TYPE_FROM_INSTANCE (file2))
     return FALSE;