From: Eric Paris Date: Fri, 24 Aug 2012 19:58:45 +0000 (-0400) Subject: SELinux: remove crazy contortions around proc X-Git-Tag: accepted/tizen/common/20141203.182822~315^2~11^2~17^2~13 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=40d3d0b85fa22084fc3b7eeb943aca365097cea3;p=platform%2Fkernel%2Flinux-arm64.git SELinux: remove crazy contortions around proc We check if the fsname is proc and if so set the proc superblock security struct flag. We then check if the flag is set and use the string 'proc' for the fsname instead of just using the fsname. What's the point? It's always proc... Get rid of the useless conditional. Signed-off-by: Eric Paris --- diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c index 911b780..42b538c 100644 --- a/security/selinux/hooks.c +++ b/security/selinux/hooks.c @@ -678,7 +678,7 @@ static int selinux_set_mnt_opts(struct super_block *sb, sbsec->flags |= SE_SBPROC; /* Determine the labeling behavior to use for this filesystem type. */ - rc = security_fs_use((sbsec->flags & SE_SBPROC) ? "proc" : sb->s_type->name, &sbsec->behavior, &sbsec->sid); + rc = security_fs_use(sb->s_type->name, &sbsec->behavior, &sbsec->sid); if (rc) { printk(KERN_WARNING "%s: security_fs_use(%s) returned %d\n", __func__, sb->s_type->name, rc);