From: Nicholas Clark <nick@ccl4.org>
Date: Tue, 11 Apr 2006 18:06:30 +0000 (+0000)
Subject: Within Perl_newSVhek, inline most of newSVpvn_share(), because
X-Git-Tag: accepted/trunk/20130322.191538~18003
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=409dfe773507bb644ee4393d7be6447672587c1d;p=platform%2Fupstream%2Fperl.git

Within Perl_newSVhek, inline most of newSVpvn_share(), because
share_hek_hek() is far more efficient than sharepvn().

p4raw-id: //depot/perl@27767
---

diff --git a/sv.c b/sv.c
index 02e83a1..e84b0e5 100644
--- a/sv.c
+++ b/sv.c
@@ -6964,9 +6964,23 @@ Perl_newSVhek(pTHX_ const HEK *hek)
 	    return sv;
 	}
 	/* This will be overwhelminly the most common case.  */
-	return newSVpvn_share(HEK_KEY(hek),
-			      (HEK_UTF8(hek) ? -HEK_LEN(hek) : HEK_LEN(hek)),
-			      HEK_HASH(hek));
+	{
+	    /* Inline most of newSVpvn_share(), because share_hek_hek() is far
+	       more efficient than sharepvn().  */
+	    SV *sv;
+
+	    new_SV(sv);
+	    sv_upgrade(sv, SVt_PV);
+	    SvPV_set(sv, (char *)HEK_KEY(share_hek_hek(hek)));
+	    SvCUR_set(sv, HEK_LEN(hek));
+	    SvLEN_set(sv, 0);
+	    SvREADONLY_on(sv);
+	    SvFAKE_on(sv);
+	    SvPOK_on(sv);
+	    if (HEK_UTF8(hek))
+		SvUTF8_on(sv);
+	    return sv;
+	}
     }
 }