From: Dave Young Date: Fri, 20 Dec 2013 10:02:15 +0000 (+0800) Subject: x86/efi: Fix off-by-one bug in EFI Boot Services reservation X-Git-Tag: submit/tizen_common/20140905.094502~982 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=408860f39b5924308f30f5d5d0a6472756e73922;p=sdk%2Femulator%2Femulator-kernel.git x86/efi: Fix off-by-one bug in EFI Boot Services reservation commit a7f84f03f660d93574ac88835d056c0d6468aebe upstream. Current code check boot service region with kernel text region by: start+size >= __pa_symbol(_text) The end of the above region should be start + size - 1 instead. I see this problem in ovmf + Fedora 19 grub boot: text start: 1000000 md start: 800000 md size: 800000 Signed-off-by: Dave Young Acked-by: Borislav Petkov Acked-by: Toshi Kani Tested-by: Toshi Kani Signed-off-by: Matt Fleming Signed-off-by: Greg Kroah-Hartman --- diff --git a/arch/x86/platform/efi/efi.c b/arch/x86/platform/efi/efi.c index 220fa52b9bd0..f19284d87dfe 100644 --- a/arch/x86/platform/efi/efi.c +++ b/arch/x86/platform/efi/efi.c @@ -440,7 +440,7 @@ void __init efi_reserve_boot_services(void) * - Not within any part of the kernel * - Not the bios reserved area */ - if ((start+size >= __pa_symbol(_text) + if ((start + size > __pa_symbol(_text) && start <= __pa_symbol(_end)) || !e820_all_mapped(start, start+size, E820_RAM) || memblock_is_region_reserved(start, size)) {