From: Tom Bailey Date: Wed, 2 Aug 2017 17:17:08 +0000 (+0100) Subject: adaptivedemux: Fix leak of pad probes in GstAdaptiveDemuxStream X-Git-Tag: 1.19.3~507^2~4971 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4064683d36ba8eb8732b904be0bdaedc38b013fc;p=platform%2Fupstream%2Fgstreamer.git adaptivedemux: Fix leak of pad probes in GstAdaptiveDemuxStream This commit ensures that the idle probe which GstAdaptiveDemuxStream adds to the upstream source pad is removed after use. Previously a new probe was added to the pad whenever a fragment was downloaded, meaning the number of pad probe callbacks being executed increased continually. https://bugzilla.gnome.org/show_bug.cgi?id=785957 --- diff --git a/gst-libs/gst/adaptivedemux/gstadaptivedemux.c b/gst-libs/gst/adaptivedemux/gstadaptivedemux.c index 7b7d1fc527..9ee1a76409 100644 --- a/gst-libs/gst/adaptivedemux/gstadaptivedemux.c +++ b/gst-libs/gst/adaptivedemux/gstadaptivedemux.c @@ -3081,7 +3081,7 @@ gst_ad_stream_src_to_ready_cb (GstPad * pad, GstPadProbeInfo * info, g_cond_signal (&stream->fragment_download_cond); g_mutex_unlock (&stream->fragment_download_lock); - return GST_PAD_PROBE_OK; + return GST_PAD_PROBE_REMOVE; } #ifndef GST_DISABLE_GST_DEBUG