From: hayeswang Date: Thu, 9 Oct 2014 10:00:24 +0000 (+0800) Subject: r8152: autoresume before setting feature X-Git-Tag: v4.9.8~5486^2~81^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=405f8a0ec71c869a374066cce22f88670d27a739;p=platform%2Fkernel%2Flinux-rpi3.git r8152: autoresume before setting feature Resume the device before setting the feature. Signed-off-by: Hayes Wang Signed-off-by: David S. Miller --- diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 5cfd414..c5afe8c 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -2145,6 +2145,11 @@ static int rtl8152_set_features(struct net_device *dev, { netdev_features_t changed = features ^ dev->features; struct r8152 *tp = netdev_priv(dev); + int ret; + + ret = usb_autopm_get_interface(tp->intf); + if (ret < 0) + goto out; if (changed & NETIF_F_HW_VLAN_CTAG_RX) { if (features & NETIF_F_HW_VLAN_CTAG_RX) @@ -2153,7 +2158,10 @@ static int rtl8152_set_features(struct net_device *dev, rtl_rx_vlan_en(tp, false); } - return 0; + usb_autopm_put_interface(tp->intf); + +out: + return ret; } #define WAKE_ANY (WAKE_PHY | WAKE_MAGIC | WAKE_UCAST | WAKE_BCAST | WAKE_MCAST)