From: Zbigniew Jędrzejewski-Szmek <zbyszek@in.waw.pl>
Date: Sun, 15 Jan 2017 18:42:53 +0000 (-0500)
Subject: shared/install-printf: fix memleak
X-Git-Tag: v234~635^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=402a81c7742ee8b66f93f9eb1e7cb6227b6768e4;p=platform%2Fupstream%2Fsystemd.git

shared/install-printf: fix memleak

instance might be "", and that string would be leaked.

CID #1368264.
---

diff --git a/src/shared/install-printf.c b/src/shared/install-printf.c
index 823fb61..c10ed3d 100644
--- a/src/shared/install-printf.c
+++ b/src/shared/install-printf.c
@@ -93,9 +93,9 @@ static int specifier_instance(char specifier, void *data, void *userdata, char *
                 return r;
 
         if (isempty(instance)) {
-                instance = strdup(i->default_instance ?: "");
-                if (!instance)
-                        return -ENOMEM;
+                r = free_and_strdup(&instance, i->default_instance ?: "");
+                if (r < 0)
+                        return r;
         }
 
         *ret = instance;