From: Ian Romanick Date: Fri, 26 Mar 2010 21:38:37 +0000 (-0700) Subject: Replace is_integer_base_type macro with glsl_type::is_integer method X-Git-Tag: 062012170305~10660^2~625^2~569 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=40176e249f72b6090204611873b19aed3da67c71;p=profile%2Fivi%2Fmesa.git Replace is_integer_base_type macro with glsl_type::is_integer method --- diff --git a/ast_to_hir.cpp b/ast_to_hir.cpp index 40a980f..890dc8e 100644 --- a/ast_to_hir.cpp +++ b/ast_to_hir.cpp @@ -255,8 +255,7 @@ modulus_result_type(const struct glsl_type *type_a, * integer vectors. The operand types must both be signed or both be * unsigned." */ - if (! is_integer_base_type(type_a->base_type) - || ! is_integer_base_type(type_b->base_type) + if (!type_a->is_integer() || !type_b->is_integer() || (type_a->base_type != type_b->base_type)) { return glsl_type::error_type; } diff --git a/glsl_types.h b/glsl_types.h index e051301..9af8e9d 100644 --- a/glsl_types.h +++ b/glsl_types.h @@ -42,9 +42,6 @@ #define is_numeric_base_type(b) \ (((b) >= GLSL_TYPE_UINT) && ((b) <= GLSL_TYPE_FLOAT)) -#define is_integer_base_type(b) \ - (((b) == GLSL_TYPE_UINT) || ((b) == GLSL_TYPE_INT)) - #define is_error_type(t) ((t)->base_type == GLSL_TYPE_ERROR) enum glsl_sampler_dim { @@ -204,6 +201,14 @@ struct glsl_type { } /** + * Query whether or not a type is an integral type + */ + bool is_integer() const + { + return (base_type == GLSL_TYPE_UINT) || (base_type == GLSL_TYPE_INT); + } + + /** * Query whether or not a type is a non-array boolean type */ bool is_boolean() const