From: John Fastabend <john.r.fastabend@intel.com>
Date: Tue, 21 Jun 2011 07:35:04 +0000 (+0000)
Subject: dcb: Add missing error check in dcb_ieee_set()
X-Git-Tag: upstream/snapshot3+hdmi~9624^2~366
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=4003b65871c101eb5ce8f37a325feac54aa5c681;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git

dcb: Add missing error check in dcb_ieee_set()

Missing error checking before nla_parse_nested().

Reported-by: Mark Rustad <mark.d.rustad@intel.com>
Signed-off-by: John Fastabend <john.r.fastabend@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/dcb/dcbnl.c b/net/dcb/dcbnl.c
index f54c784..e954d4c 100644
--- a/net/dcb/dcbnl.c
+++ b/net/dcb/dcbnl.c
@@ -1368,6 +1368,9 @@ static int dcbnl_ieee_set(struct net_device *netdev, struct nlattr **tb,
 	if (!ops)
 		return err;
 
+	if (!tb[DCB_ATTR_IEEE])
+		return -EINVAL;
+
 	err = nla_parse_nested(ieee, DCB_ATTR_IEEE_MAX,
 			       tb[DCB_ATTR_IEEE], dcbnl_ieee_policy);
 	if (err)