From: Yuan Can <yuancan@huawei.com>
Date: Thu, 24 Nov 2022 11:33:32 +0000 (+0000)
Subject: HSI: omap_ssi_core: Fix error handling in ssi_init()
X-Git-Tag: v6.6.17~5890^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3ffa9f713c39a213a08d9ff13ab983a8aa5d8b5d;p=platform%2Fkernel%2Flinux-rpi.git

HSI: omap_ssi_core: Fix error handling in ssi_init()

The ssi_init() returns the platform_driver_register() directly without
checking its return value, if platform_driver_register() failed, the
ssi_pdriver is not unregistered.
Fix by unregister ssi_pdriver when the last platform_driver_register()
failed.

Fixes: 0fae198988b8 ("HSI: omap_ssi: built omap_ssi and omap_ssi_port into one module")
Signed-off-by: Yuan Can <yuancan@huawei.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---

diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c
index 052cf3e..26f2c3c 100644
--- a/drivers/hsi/controllers/omap_ssi_core.c
+++ b/drivers/hsi/controllers/omap_ssi_core.c
@@ -631,7 +631,13 @@ static int __init ssi_init(void) {
 	if (ret)
 		return ret;
 
-	return platform_driver_register(&ssi_port_pdriver);
+	ret = platform_driver_register(&ssi_port_pdriver);
+	if (ret) {
+		platform_driver_unregister(&ssi_pdriver);
+		return ret;
+	}
+
+	return 0;
 }
 module_init(ssi_init);