From: Jesper Juhl Date: Mon, 9 Apr 2012 19:50:04 +0000 (-0300) Subject: [media] s2255drv: Remove redundant NULL test before release_firmware() X-Git-Tag: accepted/tizen/common/20141203.182822~2038^2~2460 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3fc82fa001cac8f22e7493a02c795f2bb33cafac;p=platform%2Fkernel%2Flinux-arm64.git [media] s2255drv: Remove redundant NULL test before release_firmware() release_firmware() tests for NULL pointers on its own - there's no reason to do an explicit check before calling the function. Signed-off-by: Jesper Juhl Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/video/s2255drv.c b/drivers/media/video/s2255drv.c index 4894cbb..37845de 100644 --- a/drivers/media/video/s2255drv.c +++ b/drivers/media/video/s2255drv.c @@ -1826,8 +1826,7 @@ static void s2255_destroy(struct s2255_dev *dev) usb_free_urb(dev->fw_data->fw_urb); dev->fw_data->fw_urb = NULL; } - if (dev->fw_data->fw) - release_firmware(dev->fw_data->fw); + release_firmware(dev->fw_data->fw); kfree(dev->fw_data->pfw_data); kfree(dev->fw_data); /* reset the DSP so firmware can be reloaded next time */