From: Jeongho Mok <jho.mok@samsung.com>
Date: Wed, 11 Jan 2017 11:08:34 +0000 (+0900)
Subject: Check state and isInThread when pause/resume
X-Git-Tag: accepted/tizen/3.0/common/20170113.182103^0
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3fb18ff5f2ad35c39e2f16148f5dc87f191dabff;p=platform%2Fcore%2Fapi%2Faudio-io.git

Check state and isInThread when pause/resume

[Version] 0.3.53
[Profile] Common
[Issue Type] SVACE

Change-Id: I72c8ab825741283dc930646bfaa530b6e49f57fa
---

diff --git a/include/CAudioError.h b/include/CAudioError.h
index e683c6c..43ec587 100644
--- a/include/CAudioError.h
+++ b/include/CAudioError.h
@@ -40,6 +40,7 @@ namespace tizen_media_audio {
             ERROR_INVALID_FORMAT,
             ERROR_INVALID_POINTER,
             ERROR_INVALID_OPERATION,
+            ERROR_INVALID_STATE,
 
             ERROR_NOT_INITIALIZED,
             ERROR_NOT_SUPPORTED,
diff --git a/packaging/capi-media-audio-io.spec b/packaging/capi-media-audio-io.spec
index 1be2102..039871a 100644
--- a/packaging/capi-media-audio-io.spec
+++ b/packaging/capi-media-audio-io.spec
@@ -1,6 +1,6 @@
 Name:           capi-media-audio-io
 Summary:        An Audio Input & Audio Output library in Tizen Native API
-Version:        0.3.52
+Version:        0.3.53
 Release:        0
 Group:          Multimedia/API
 License:        Apache-2.0
diff --git a/src/cpp/CAudioError.cpp b/src/cpp/CAudioError.cpp
index d429f66..ed61465 100644
--- a/src/cpp/CAudioError.cpp
+++ b/src/cpp/CAudioError.cpp
@@ -88,6 +88,7 @@ const char* CAudioError::__convertErrorToString(EError err) {
     case EError::ERROR_INVALID_FORMAT:      return COLOR_RED   "ERROR_INVALID_FORMAT"     COLOR_END;
     case EError::ERROR_INVALID_POINTER:     return COLOR_RED   "ERROR_INVALID_POINTER"    COLOR_END;
     case EError::ERROR_INVALID_OPERATION:   return COLOR_RED   "ERROR_INVALID_OPERATION"  COLOR_END;
+    case EError::ERROR_INVALID_STATE:       return COLOR_RED   "ERROR_INVALID_STATE"      COLOR_END;
     case EError::ERROR_NOT_INITIALIZED:     return COLOR_RED   "ERROR_NOT_INITIALIZED"    COLOR_END;
     case EError::ERROR_NOT_SUPPORTED:       return COLOR_RED   "ERROR_NOT_SUPPORTED"      COLOR_END;
     case EError::ERROR_NOT_SUPPORTED_TYPE:  return COLOR_RED   "ERROR_NOT_SUPPORTED_TYPE" COLOR_END;
diff --git a/src/cpp/CAudioInput.cpp b/src/cpp/CAudioInput.cpp
index 1e53881..3887ddb 100644
--- a/src/cpp/CAudioInput.cpp
+++ b/src/cpp/CAudioInput.cpp
@@ -333,6 +333,15 @@ void CAudioInput::pause() throw(CAudioError) {
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize or prepare CAudioInput");
     }
 
+    if (CAudioIO::getState() != CAudioInfo::EAudioIOState::AUDIO_IO_STATE_RUNNING) {
+        THROW_ERROR_MSG(CAudioError::EError::ERROR_INVALID_STATE,
+                        "Can't pause if not in Running state");
+    }
+
+    if (mpPulseAudioClient->isInThread() == true) {
+        THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INVALID_OPERATION, "Can't pause in thread");
+    }
+
     try {
         CAudioIO::pause();
 
@@ -357,6 +366,15 @@ void CAudioInput::resume() throw(CAudioError) {
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize or prepare CAudioInput");
     }
 
+    if (CAudioIO::getState() != CAudioInfo::EAudioIOState::AUDIO_IO_STATE_PAUSED) {
+        THROW_ERROR_MSG(CAudioError::EError::ERROR_INVALID_STATE,
+                        "Can't resume if not in Paused state");
+    }
+
+    if (mpPulseAudioClient->isInThread() == true) {
+        THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INVALID_OPERATION, "Can't resume in thread");
+    }
+
     try {
         internalLock();
 
diff --git a/src/cpp/CAudioOutput.cpp b/src/cpp/CAudioOutput.cpp
index fbbe8ea..19de90f 100644
--- a/src/cpp/CAudioOutput.cpp
+++ b/src/cpp/CAudioOutput.cpp
@@ -230,6 +230,15 @@ void CAudioOutput::pause() throw(CAudioError) {
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize or prepare CAudioOutput");
     }
 
+    if (CAudioIO::getState() != CAudioInfo::EAudioIOState::AUDIO_IO_STATE_RUNNING) {
+        THROW_ERROR_MSG(CAudioError::EError::ERROR_INVALID_STATE,
+                        "Can't pause if not in Running state");
+    }
+
+    if (mpPulseAudioClient->isInThread() == true) {
+        THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INVALID_OPERATION, "Can't pause in thread");
+    }
+
     try {
         CAudioIO::pause();
 
@@ -254,6 +263,15 @@ void CAudioOutput::resume() throw(CAudioError) {
         THROW_ERROR_MSG(CAudioError::EError::ERROR_NOT_INITIALIZED, "Did not initialize or prepare CAudioOutput");
     }
 
+    if (CAudioIO::getState() != CAudioInfo::EAudioIOState::AUDIO_IO_STATE_PAUSED) {
+        THROW_ERROR_MSG(CAudioError::EError::ERROR_INVALID_STATE,
+                        "Can't resume if not in Paused state");
+    }
+
+    if (mpPulseAudioClient->isInThread() == true) {
+        THROW_ERROR_MSG_FORMAT(CAudioError::EError::ERROR_INVALID_OPERATION, "Can't resume in thread");
+    }
+
     try {
         internalLock();
 
diff --git a/src/cpp/cpp_audio_io.cpp b/src/cpp/cpp_audio_io.cpp
index 902107e..bbb30b6 100644
--- a/src/cpp/cpp_audio_io.cpp
+++ b/src/cpp/cpp_audio_io.cpp
@@ -133,6 +133,9 @@ static audio_io_error_e __convert_CAudioError(CAudioError& error) {
     case CAudioError::EError::ERROR_INVALID_OPERATION:
         ret = AUDIO_IO_ERROR_INVALID_OPERATION;
         break;
+    case CAudioError::EError::ERROR_INVALID_STATE:
+        ret = AUDIO_IO_ERROR_INVALID_STATE;
+        break;
     case CAudioError::EError::ERROR_OUT_OF_MEMORY:
     case CAudioError::EError::ERROR_INVALID_POINTER:
         ret = AUDIO_IO_ERROR_INVALID_BUFFER;