From: Tomas Mlcoch <tmlcoch@redhat.com>
Date: Tue, 28 Apr 2015 13:19:43 +0000 (+0200)
Subject: xml_dumpers: Return GError when no obj to dump is passed
X-Git-Tag: upstream/0.10.0~99
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3f82ef7daa80fc46c06d6dfc5aef30a6d558a3b7;p=services%2Fcreaterepo_c.git

xml_dumpers: Return GError when no obj to dump is passed
---

diff --git a/src/xml_dump_deltapackage.c b/src/xml_dump_deltapackage.c
index 089dc53..6ace7b5 100644
--- a/src/xml_dump_deltapackage.c
+++ b/src/xml_dump_deltapackage.c
@@ -109,8 +109,11 @@ cr_xml_dump_deltapackage(cr_DeltaPackage *package, GError **err)
 
     assert(!err || *err == NULL);
 
-    if (!package)
+    if (!package) {
+        g_set_error(err, CREATEREPO_C_ERROR, CRE_BADARG,
+                    "No package object to dump specified");
         return NULL;
+    }
 
 
     // Dump IT!
diff --git a/src/xml_dump_filelists.c b/src/xml_dump_filelists.c
index 3a4d237..4e8140c 100644
--- a/src/xml_dump_filelists.c
+++ b/src/xml_dump_filelists.c
@@ -81,8 +81,11 @@ cr_xml_dump_filelists(cr_Package *package, GError **err)
 
     assert(!err || *err == NULL);
 
-    if (!package)
+    if (!package) {
+        g_set_error(err, CREATEREPO_C_ERROR, CRE_BADARG,
+                    "No package object to dump specified");
         return NULL;
+    }
 
 
     // Dump IT!
diff --git a/src/xml_dump_other.c b/src/xml_dump_other.c
index 4dbd9a7..7efc483 100644
--- a/src/xml_dump_other.c
+++ b/src/xml_dump_other.c
@@ -120,8 +120,11 @@ cr_xml_dump_other(cr_Package *package, GError **err)
 
     assert(!err || *err == NULL);
 
-    if (!package)
+    if (!package) {
+        g_set_error(err, CREATEREPO_C_ERROR, CRE_BADARG,
+                    "No package object to dump specified");
         return NULL;
+    }
 
 
     // Dump IT!
diff --git a/src/xml_dump_primary.c b/src/xml_dump_primary.c
index 960f111..5695e06 100644
--- a/src/xml_dump_primary.c
+++ b/src/xml_dump_primary.c
@@ -383,9 +383,11 @@ cr_xml_dump_primary(cr_Package *package, GError **err)
 
     assert(!err || *err == NULL);
 
-    if (!package)
+    if (!package) {
+        g_set_error(err, CREATEREPO_C_ERROR, CRE_BADARG,
+                    "No package object to dump specified");
         return NULL;
-
+    }
 
     // Dump IT!
 
diff --git a/src/xml_dump_repomd.c b/src/xml_dump_repomd.c
index c1b3f7e..842c585 100644
--- a/src/xml_dump_repomd.c
+++ b/src/xml_dump_repomd.c
@@ -215,8 +215,11 @@ cr_xml_dump_repomd(cr_Repomd *repomd, GError **err)
 
     assert(!err || *err == NULL);
 
-    if (!repomd)
+    if (!repomd) {
+        g_set_error(err, CREATEREPO_C_ERROR, CRE_BADARG,
+                    "No repomd object to dump specified");
         return NULL;
+    }
 
 
     // Dump IT!
diff --git a/src/xml_dump_updateinfo.c b/src/xml_dump_updateinfo.c
index fb8753a..b9f3b96 100644
--- a/src/xml_dump_updateinfo.c
+++ b/src/xml_dump_updateinfo.c
@@ -207,8 +207,11 @@ cr_xml_dump_updaterecord(cr_UpdateRecord *rec, GError **err)
 
     assert(!err || *err == NULL);
 
-    if (!rec)
+    if (!rec) {
+        g_set_error(err, CREATEREPO_C_ERROR, CRE_BADARG,
+                    "No updateinfo object to dump specified");
         return NULL;
+    }
 
     // Dump IT!