From: Craig Topper Date: Mon, 17 Feb 2020 22:49:17 +0000 (-0800) Subject: [X86] Add one use check to '0-x == y --> x+y == 0' in EmitCmp. X-Git-Tag: llvmorg-12-init~14432 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3f4490d384c8b3c41bd9f8a4a17467769c7a55c0;p=platform%2Fupstream%2Fllvm.git [X86] Add one use check to '0-x == y --> x+y == 0' in EmitCmp. I failed to copy it when I moved this in b62de210cf50ccb6822260e4075dd93333adb23e --- diff --git a/llvm/lib/Target/X86/X86ISelLowering.cpp b/llvm/lib/Target/X86/X86ISelLowering.cpp index 96d41ed..275a7bd 100644 --- a/llvm/lib/Target/X86/X86ISelLowering.cpp +++ b/llvm/lib/Target/X86/X86ISelLowering.cpp @@ -21212,7 +21212,7 @@ static SDValue EmitCmp(SDValue Op0, SDValue Op1, unsigned X86CC, // 0-x == y --> x+y == 0 // 0-x != y --> x+y != 0 if (Op0.getOpcode() == ISD::SUB && isNullConstant(Op0.getOperand(0)) && - (X86CC == X86::COND_E || X86CC == X86::COND_NE)) { + Op0.hasOneUse() && (X86CC == X86::COND_E || X86CC == X86::COND_NE)) { SDVTList VTs = DAG.getVTList(CmpVT, MVT::i32); SDValue Add = DAG.getNode(X86ISD::ADD, dl, VTs, Op0.getOperand(1), Op1); return Add.getValue(1); @@ -21221,7 +21221,7 @@ static SDValue EmitCmp(SDValue Op0, SDValue Op1, unsigned X86CC, // x == 0-y --> x+y == 0 // x != 0-y --> x+y != 0 if (Op1.getOpcode() == ISD::SUB && isNullConstant(Op1.getOperand(0)) && - (X86CC == X86::COND_E || X86CC == X86::COND_NE)) { + Op1.hasOneUse() && (X86CC == X86::COND_E || X86CC == X86::COND_NE)) { SDVTList VTs = DAG.getVTList(CmpVT, MVT::i32); SDValue Add = DAG.getNode(X86ISD::ADD, dl, VTs, Op0, Op1.getOperand(1)); return Add.getValue(1);