From: Yishai Hadas Date: Thu, 4 Mar 2021 13:04:59 +0000 (+0200) Subject: IB/core: Drop WARN_ON() from ib_umem_find_best_pgsz() X-Git-Tag: accepted/tizen/unified/20230118.172025~7319^2~127 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3f32dc0f4601b180bbfd7b5adc7f82557f1408d0;p=platform%2Fkernel%2Flinux-rpi.git IB/core: Drop WARN_ON() from ib_umem_find_best_pgsz() The WARN_ON() issued as part of ib_umem_find_best_pgsz() blocked cases when only page sizes larger than PAGE_SIZE were set, drop it to enable those cases. In addition, there is no need to have a specific check for zero pgsz_bitmap, the function will do its job and return 0 at the end if nothing match will be found. Link: https://lore.kernel.org/r/20210304130501.1102577-2-leon@kernel.org Signed-off-by: Yishai Hadas Signed-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe --- diff --git a/drivers/infiniband/core/umem.c b/drivers/infiniband/core/umem.c index 2dde99a..2cd6464 100644 --- a/drivers/infiniband/core/umem.c +++ b/drivers/infiniband/core/umem.c @@ -100,10 +100,6 @@ unsigned long ib_umem_find_best_pgsz(struct ib_umem *umem, */ pgsz_bitmap &= GENMASK(BITS_PER_LONG - 1, PAGE_SHIFT); - /* At minimum, drivers must support PAGE_SIZE or smaller */ - if (WARN_ON(!(pgsz_bitmap & GENMASK(PAGE_SHIFT, 0)))) - return 0; - umem->iova = va = virt; /* The best result is the smallest page size that results in the minimum * number of required pages. Compute the largest page size that could