From: Georg Hofmann Date: Thu, 14 Mar 2013 06:54:09 +0000 (+0000) Subject: net: fec: fix missing napi_disable call X-Git-Tag: v5.15~20493^2~19 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3f104c38259dcb3e5443c246f0805bc04d887cc3;p=platform%2Fkernel%2Flinux-starfive.git net: fec: fix missing napi_disable call Commit dc975382d2ef36be7e78fac3717927de1a5abcd8 introduces napi support but never calls napi_disable. This will generate a kernel oops (kernel BUG at include/linux/netdevice.h:473!) every time, when ndo_stop is called followed by ndo_start. Add the missing napi_diable call. Signed-off-by: Georg Hofmann Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/freescale/fec.c b/drivers/net/ethernet/freescale/fec.c index 61d2e62..e3f3937 100644 --- a/drivers/net/ethernet/freescale/fec.c +++ b/drivers/net/ethernet/freescale/fec.c @@ -1441,6 +1441,7 @@ fec_enet_close(struct net_device *ndev) struct fec_enet_private *fep = netdev_priv(ndev); /* Don't know what to do yet. */ + napi_disable(&fep->napi); fep->opened = 0; netif_stop_queue(ndev); fec_stop(ndev);