From: Dave Lerner Date: Fri, 11 Apr 2014 22:19:28 +0000 (-0500) Subject: bitbake: toaster: fix span2 headings for packages X-Git-Tag: rev_ivi_2015_02_04~8097 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3ee9758496d9ca2cc5ef1d1373cffee587aa75d9;p=scm%2Fbb%2Ftizen-distro.git bitbake: toaster: fix span2 headings for packages [YOCTO 6147] Fix bug in views.py that put 'span2' class id in a 'clclass' key instead of the 'dclass' key. This fix exposed another problem in target.html and the target view function that used 'package_size' instead of 'size' as the 'clclass' which is inconsistent with the model field name, causing table data columns to be shown when the header is hidden. (Bitbake rev: 436865ac8520c1d75401dde7df373dba9a386c9d) Signed-off-by: Dave Lerner Signed-off-by: Richard Purdie --- diff --git a/bitbake/lib/toaster/toastergui/templates/target.html b/bitbake/lib/toaster/toastergui/templates/target.html index 86e46dc..564fd27 100644 --- a/bitbake/lib/toaster/toastergui/templates/target.html +++ b/bitbake/lib/toaster/toastergui/templates/target.html @@ -79,7 +79,7 @@ {{package.version|filtered_packageversion:package.revision}} - + {{package.size|filtered_installedsize:package.installed_size|filtered_filesizeformat}} diff --git a/bitbake/lib/toaster/toastergui/views.py b/bitbake/lib/toaster/toastergui/views.py index 3d2ed4c..e3b24ba 100644 --- a/bitbake/lib/toaster/toastergui/views.py +++ b/bitbake/lib/toaster/toastergui/views.py @@ -575,13 +575,15 @@ def target(request, build_id, target_id): 'qhelp':'The size of the package', 'orderfield': _get_toggle_order(request, "size", True), 'ordericon':_get_toggle_order_icon(request, "size"), - 'clclass': 'package_size span2', + 'clclass': 'size', + 'dclass' : 'span2', 'hidden' : 0, }, { 'name':'Size over total (%)', 'qhelp':'Proportion of the overall included package size represented by this package', - 'clclass': 'size_over_total span2', + 'clclass': 'size_over_total', + 'dclass' : 'span2', 'hidden' : 1, }, { @@ -1273,7 +1275,8 @@ def bpackage(request, build_id): 'qhelp':'The size of the package', 'orderfield': _get_toggle_order(request, "size", True), 'ordericon':_get_toggle_order_icon(request, "size"), - 'clclass': 'size span2', 'hidden': 0, + 'clclass': 'size', 'hidden': 0, + 'dclass' : 'span2', }, { 'name':'License',