From: Yonggil Song Date: Tue, 22 Nov 2022 09:03:20 +0000 (+0900) Subject: f2fs: avoid victim selection from previous victim section X-Git-Tag: v6.1.8~1304 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3ee8611a1d0dbf5b229d3d165d76d5d3ab3a5a84;p=platform%2Fkernel%2Flinux-starfive.git f2fs: avoid victim selection from previous victim section [ Upstream commit e219aecfd4b766c4e878a3769057e9809f7fcadc ] When f2fs chooses GC victim in large section & LFS mode, next_victim_seg[gc_type] is referenced first. After segment is freed, next_victim_seg[gc_type] has the next segment number. However, next_victim_seg[gc_type] still has the last segment number even after the last segment of section is freed. In this case, when f2fs chooses a victim for the next GC round, the last segment of previous victim section is chosen as a victim. Initialize next_victim_seg[gc_type] to NULL_SEGNO for the last segment in large section. Fixes: e3080b0120a1 ("f2fs: support subsectional garbage collection") Signed-off-by: Yonggil Song Reviewed-by: Chao Yu Signed-off-by: Jaegeuk Kim Signed-off-by: Sasha Levin --- diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index f46e4dc..22c1f87 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -1743,8 +1743,9 @@ freed: get_valid_blocks(sbi, segno, false) == 0) seg_freed++; - if (__is_large_section(sbi) && segno + 1 < end_segno) - sbi->next_victim_seg[gc_type] = segno + 1; + if (__is_large_section(sbi)) + sbi->next_victim_seg[gc_type] = + (segno + 1 < end_segno) ? segno + 1 : NULL_SEGNO; skip: f2fs_put_page(sum_page, 0); }