From: Tommie Gannert Date: Mon, 17 Feb 2014 20:46:04 +0000 (+0000) Subject: irtty-sir.c: Do not set_termios() on irtty_close() X-Git-Tag: upstream/snapshot3+hdmi~3396^2~9 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3eca5299532ea9d6ab63b03e7aaac9071d5eed29;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git irtty-sir.c: Do not set_termios() on irtty_close() Issuing set_termios() from irtty_close() causes kernel Oops for unplugged usb-serial devices. Since no other tty_ldisc calls set_termios() on close and no tty driver seem to check if tty->device_data is NULL or not on entry to set_termios(), the only solution I can come up with is to remove the irtty_stop_receiver() call, which only updates termios. Signed-off-by: Tommie Gannert Signed-off-by: David S. Miller --- diff --git a/drivers/net/irda/irtty-sir.c b/drivers/net/irda/irtty-sir.c index 177441a..24b6ddd 100644 --- a/drivers/net/irda/irtty-sir.c +++ b/drivers/net/irda/irtty-sir.c @@ -522,7 +522,6 @@ static void irtty_close(struct tty_struct *tty) sirdev_put_instance(priv->dev); /* Stop tty */ - irtty_stop_receiver(tty, TRUE); clear_bit(TTY_DO_WRITE_WAKEUP, &tty->flags); if (tty->ops->stop) tty->ops->stop(tty);