From: Mitchell Hwang <16830051+mdh1418@users.noreply.github.com>
Date: Thu, 5 Sep 2024 00:44:12 +0000 (-0400)
Subject: [tests] Update EventLogsPipelineUnitTests referenced issue (#4905)
X-Git-Tag: accepted/tizen/unified/20241231.014852~39^2^2~41
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3eb66d2099e2ae44ebae497ea9b447fcdfb356a9;p=platform%2Fcore%2Fdotnet%2Fdiagnostics.git

[tests] Update EventLogsPipelineUnitTests referenced issue (#4905)

Some EventLogsPipelineUnitTests originally disabled for Windows began
failing on other platforms. They were additionally disabled for all
platforms, referencing issue
https://github.com/dotnet/diagnostics/issues/4718.

https://github.com/dotnet/diagnostics/issues/4718 was closed, opting to
use https://github.com/dotnet/diagnostics/issues/2541 as the main
tracking issue.

Update the issue reference to reflect this.
---

diff --git a/src/tests/Microsoft.Diagnostics.Monitoring.EventPipe/EventLogsPipelineUnitTests.cs b/src/tests/Microsoft.Diagnostics.Monitoring.EventPipe/EventLogsPipelineUnitTests.cs
index 7cc92be71..c8ed1e4f2 100644
--- a/src/tests/Microsoft.Diagnostics.Monitoring.EventPipe/EventLogsPipelineUnitTests.cs
+++ b/src/tests/Microsoft.Diagnostics.Monitoring.EventPipe/EventLogsPipelineUnitTests.cs
@@ -68,14 +68,9 @@ namespace Microsoft.Diagnostics.Monitoring.EventPipe.UnitTests
         /// <summary>
         /// Test that log events at or above the default level are collected.
         /// </summary>
-        [SkippableTheory(Skip = "https://github.com/dotnet/diagnostics/issues/4718"), MemberData(nameof(Configurations))]
+        [SkippableTheory(Skip = "https://github.com/dotnet/diagnostics/issues/2541"), MemberData(nameof(Configurations))]
         public async Task TestLogsAllCategoriesDefaultLevel(TestConfiguration config)
         {
-            if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
-            {
-                throw new SkipTestException("https://github.com/dotnet/diagnostics/issues/2541");
-            }
-
             using Stream outputStream = await GetLogsAsync(config, settings => {
                 settings.UseAppFilters = false;
                 settings.LogLevel = LogLevel.Warning;
@@ -169,14 +164,9 @@ namespace Microsoft.Diagnostics.Monitoring.EventPipe.UnitTests
         /// Test that log events are collected for the categories and levels specified by the application
         /// and for the categories and levels specified in the filter specs.
         /// </summary>
-        [SkippableTheory(Skip = "https://github.com/dotnet/diagnostics/issues/4718"), MemberData(nameof(Configurations))]
+        [SkippableTheory(Skip = "https://github.com/dotnet/diagnostics/issues/2541"), MemberData(nameof(Configurations))]
         public async Task TestLogsUseAppFiltersAndFilterSpecs(TestConfiguration config)
         {
-            if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
-            {
-                throw new SkipTestException("https://github.com/dotnet/diagnostics/issues/2541");
-            }
-
             using Stream outputStream = await GetLogsAsync(config, settings => {
                 settings.FilterSpecs = new Dictionary<string, LogLevel?>()
                 {