From: Eric Dumazet Date: Wed, 8 Jun 2022 16:04:33 +0000 (-0700) Subject: net: use WARN_ON_ONCE() in inet_sock_destruct() X-Git-Tag: v6.1-rc5~731^2~386^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3e7f2b8d30883f27ab1157bf3f23f30f1a07bf69;p=platform%2Fkernel%2Flinux-starfive.git net: use WARN_ON_ONCE() in inet_sock_destruct() inet_sock_destruct() has four warnings which have been useful to point to kernel bugs in the past. However they are potentially a problem because they could flood the syslog. Signed-off-by: Eric Dumazet Signed-off-by: Jakub Kicinski --- diff --git a/net/ipv4/af_inet.c b/net/ipv4/af_inet.c index 93da9f7..30e0e89 100644 --- a/net/ipv4/af_inet.c +++ b/net/ipv4/af_inet.c @@ -148,10 +148,10 @@ void inet_sock_destruct(struct sock *sk) return; } - WARN_ON(atomic_read(&sk->sk_rmem_alloc)); - WARN_ON(refcount_read(&sk->sk_wmem_alloc)); - WARN_ON(sk->sk_wmem_queued); - WARN_ON(sk_forward_alloc_get(sk)); + WARN_ON_ONCE(atomic_read(&sk->sk_rmem_alloc)); + WARN_ON_ONCE(refcount_read(&sk->sk_wmem_alloc)); + WARN_ON_ONCE(sk->sk_wmem_queued); + WARN_ON_ONCE(sk_forward_alloc_get(sk)); kfree(rcu_dereference_protected(inet->inet_opt, 1)); dst_release(rcu_dereference_protected(sk->sk_dst_cache, 1));