From: JP Abgrall <jpa@google.com>
Date: Wed, 6 Jul 2011 19:05:49 +0000 (-0700)
Subject: netfilter: qtaguid: fix bad-arg handling when tagging socket
X-Git-Tag: 2.1b_release~2536
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3e36912e7e413de159065dd365a166be533bd23e;p=platform%2Fkernel%2Fkernel-mfld-blackbay.git

netfilter: qtaguid: fix bad-arg handling when tagging socket

When processing args passed to the procfs ctrl, if the tag was
invalid it would exit without releasing the spin_lock...
Bye bye scheduling.

Signed-off-by: JP Abgrall <jpa@google.com>
Change-Id: Ic1480ae9d37bba687586094cf6d0274db9c5b28a
---

diff --git a/net/netfilter/xt_qtaguid.c b/net/netfilter/xt_qtaguid.c
index 3b5ab3f..3cacec0 100644
--- a/net/netfilter/xt_qtaguid.c
+++ b/net/netfilter/xt_qtaguid.c
@@ -1065,7 +1065,7 @@ static int qtaguid_ctrl_parse(const char *input, int count)
 	goto ok;
 
 err_unlock:
-	if (!sock_tag_entry)
+	if (sock_tag_entry)
 		spin_unlock_irqrestore(&sock_tag_list_lock, flags);
 err:
 ok: