From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 13 Oct 2015 07:10:48 +0000 (+0300)
Subject: ASoC: wm8955: harmless underflow in wm8955_put_deemph()
X-Git-Tag: v4.14-rc1~4199^2~9^2^4~1^3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3e2a71b232d6b6270eda72ff659c31c97899c00d;p=platform%2Fkernel%2Flinux-rpi.git

ASoC: wm8955: harmless underflow in wm8955_put_deemph()

Valid values for "deemph" are zero and one, but we mistakenly allow
negative values as well.  It's harmless but we may as well clean it up.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---

diff --git a/sound/soc/codecs/wm8955.c b/sound/soc/codecs/wm8955.c
index 12e4435..9db00d5 100644
--- a/sound/soc/codecs/wm8955.c
+++ b/sound/soc/codecs/wm8955.c
@@ -402,7 +402,7 @@ static int wm8955_put_deemph(struct snd_kcontrol *kcontrol,
 {
 	struct snd_soc_codec *codec = snd_soc_kcontrol_codec(kcontrol);
 	struct wm8955_priv *wm8955 = snd_soc_codec_get_drvdata(codec);
-	int deemph = ucontrol->value.integer.value[0];
+	unsigned int deemph = ucontrol->value.integer.value[0];
 
 	if (deemph > 1)
 		return -EINVAL;