From: Joe Eykholt Date: Fri, 6 Aug 2010 00:50:37 +0000 (-0700) Subject: [SCSI] tgt: fix warning X-Git-Tag: v2.6.36-rc1~15^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3deee42088ddcf5b23021aa089b53444797e565d;p=profile%2Fivi%2Fkernel-adaptation-intel-automotive.git [SCSI] tgt: fix warning Using scsi_tgt_lib in a new target module, we were getting the following warning and a stack traceback on every I/O completion: WARNING: at block/blk-core.c:1108 Which is claiming we may be leaking a bio. We don't leak bios (blk_rq_unmap_user should free them). Set rq->bio to NULL before calling scsi_host_put_command(). This was as advised by Fujita Tomonori. Signed-off-by: Joe Eykholt Acked-by: FUJITA Tomonori Signed-off-by: James Bottomley --- diff --git a/drivers/scsi/scsi_tgt_lib.c b/drivers/scsi/scsi_tgt_lib.c index 66241dd..c399be9 100644 --- a/drivers/scsi/scsi_tgt_lib.c +++ b/drivers/scsi/scsi_tgt_lib.c @@ -185,6 +185,7 @@ static void scsi_tgt_cmd_destroy(struct work_struct *work) dprintk("cmd %p %d %u\n", cmd, cmd->sc_data_direction, rq_data_dir(cmd->request)); scsi_unmap_user_pages(tcmd); + tcmd->rq->bio = NULL; scsi_host_put_command(scsi_tgt_cmd_to_host(cmd), cmd); }