From: Darrick J. Wong Date: Mon, 22 Apr 2019 23:28:34 +0000 (-0700) Subject: xfs: unlock inode when xfs_ioctl_setattr_get_trans can't get transaction X-Git-Tag: v5.4-rc1~1083^2~10 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3de5eab3fde1e379be65973a69ded29da3802133;p=platform%2Fkernel%2Flinux-rpi.git xfs: unlock inode when xfs_ioctl_setattr_get_trans can't get transaction We passed an inode into xfs_ioctl_setattr_get_trans with join_flags indicating which locks are held on that inode. If we can't allocate a transaction then we need to unlock the inode before we bail out, like all the other error paths do. Signed-off-by: Darrick J. Wong Reviewed-by: Dave Chinner Reviewed-by: Christoph Hellwig Reviewed-by: Brian Foster --- diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c index ae615a7..21d6f43 100644 --- a/fs/xfs/xfs_ioctl.c +++ b/fs/xfs/xfs_ioctl.c @@ -1153,7 +1153,7 @@ xfs_ioctl_setattr_get_trans( error = xfs_trans_alloc(mp, &M_RES(mp)->tr_ichange, 0, 0, 0, &tp); if (error) - return ERR_PTR(error); + goto out_unlock; xfs_ilock(ip, XFS_ILOCK_EXCL); xfs_trans_ijoin(tp, ip, XFS_ILOCK_EXCL | join_flags);