From: Michal Orzel <michalorzel.eng@gmail.com>
Date: Sat, 23 Apr 2022 11:38:07 +0000 (+0200)
Subject: block/badblocks: Remove redundant assignments
X-Git-Tag: v6.1-rc5~1167^2~48
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3de2e5f28cb133f1d9c1b2403079722d0e7b671e;p=platform%2Fkernel%2Flinux-starfive.git

block/badblocks: Remove redundant assignments

Get rid of redundant assignments to a variable sectors from functions
badblocks_check and badblocks_clear. This variable, that is a function
parameter, is being assigned a value that is never read until the end of
function.

Reported by clang-tidy [deadcode.DeadStores]

Signed-off-by: Michal Orzel <michalorzel.eng@gmail.com>
Link: https://lore.kernel.org/r/20220423113811.13335-1-michalorzel.eng@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/block/badblocks.c b/block/badblocks.c
index d390566..3afb550 100644
--- a/block/badblocks.c
+++ b/block/badblocks.c
@@ -65,7 +65,6 @@ int badblocks_check(struct badblocks *bb, sector_t s, int sectors,
 		s >>= bb->shift;
 		target += (1<<bb->shift) - 1;
 		target >>= bb->shift;
-		sectors = target - s;
 	}
 	/* 'target' is now the first block after the bad range */
 
@@ -345,7 +344,6 @@ int badblocks_clear(struct badblocks *bb, sector_t s, int sectors)
 		s += (1<<bb->shift) - 1;
 		s >>= bb->shift;
 		target >>= bb->shift;
-		sectors = target - s;
 	}
 
 	write_seqlock_irq(&bb->lock);