From: Viresh Kumar <viresh.kumar@linaro.org>
Date: Mon, 31 Aug 2015 11:51:10 +0000 (+0530)
Subject: greybus: connection: convert connected dev_warn() to dev_err()
X-Git-Tag: v4.14-rc1~2366^2~378^2~21^2~1226
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3dca03de9db7c467811bdfcb0b3b90cb9a184a8f;p=platform%2Fkernel%2Flinux-rpi.git

greybus: connection: convert connected dev_warn() to dev_err()

Failures from control-connected operations are fatal errors and
must be reported with dev_err() instead of dev_warn().

Fix it.

Reviewed-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
[ johan: do not promote disconnected warnings, update summary ]
Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
---

diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c
index 62cbeb3..f89b199 100644
--- a/drivers/staging/greybus/connection.c
+++ b/drivers/staging/greybus/connection.c
@@ -386,9 +386,9 @@ static int gb_connection_init(struct gb_connection *connection)
 
 		ret = gb_control_connected_operation(control, cport_id);
 		if (ret) {
-			dev_warn(&connection->dev,
-				 "Failed to connect CPort-%d (%d)\n",
-				 cport_id, ret);
+			dev_err(&connection->dev,
+				"Failed to connect CPort-%d (%d)\n",
+				cport_id, ret);
 			return 0;
 		}
 	}