From: hoonhee.lee <hoonhee.lee@lge.com>
Date: Fri, 15 Apr 2022 05:03:08 +0000 (+0900)
Subject: playbin3: fix missing lock when unknown stream type in pad-removed cb
X-Git-Tag: 1.22.0~1859
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3d9f25d32257c9e417c11466beb2f49b2f6492aa;p=platform%2Fupstream%2Fgstreamer.git

playbin3: fix missing lock when unknown stream type in pad-removed cb

Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/2193>
---

diff --git a/subprojects/gst-plugins-base/gst/playback/gstplaybin3.c b/subprojects/gst-plugins-base/gst/playback/gstplaybin3.c
index 7946c6a..d7089bd 100644
--- a/subprojects/gst-plugins-base/gst/playback/gstplaybin3.c
+++ b/subprojects/gst-plugins-base/gst/playback/gstplaybin3.c
@@ -3143,11 +3143,12 @@ pad_removed_cb (GstElement * decodebin, GstPad * pad, GstSourceGroup * group)
   else if (g_str_has_prefix (GST_PAD_NAME (pad), "text"))
     combine = &playbin->combiner[PLAYBIN_STREAM_TEXT];
   else
-    return;
+    goto done;
 
   combiner_release_pad (playbin, combine, pad);
   release_source_pad (playbin, group, pad);
 
+done:
   GST_PLAY_BIN3_UNLOCK (playbin);
 }