From: Maxime Chevallier Date: Thu, 5 Apr 2018 09:55:48 +0000 (+0200) Subject: net: mvpp2: Fix parser entry init boundary check X-Git-Tag: v4.19~1245^2~21 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3d92f0b582062127026af1fb5e86eda4a3b01783;p=platform%2Fkernel%2Flinux-rpi3.git net: mvpp2: Fix parser entry init boundary check Boundary check in mvpp2_prs_init_from_hw must be done according to the passed "tid" parameter, not the mvpp2_prs_entry index, which is not yet initialized at the time of the check. Fixes: 47e0e14eb1a6 ("net: mvpp2: Make mvpp2_prs_hw_read a parser entry init function") Signed-off-by: Maxime Chevallier Signed-off-by: David S. Miller --- diff --git a/drivers/net/ethernet/marvell/mvpp2.c b/drivers/net/ethernet/marvell/mvpp2.c index 7fc1bbf..54a0389 100644 --- a/drivers/net/ethernet/marvell/mvpp2.c +++ b/drivers/net/ethernet/marvell/mvpp2.c @@ -1604,7 +1604,7 @@ static int mvpp2_prs_init_from_hw(struct mvpp2 *priv, { int i; - if (pe->index > MVPP2_PRS_TCAM_SRAM_SIZE - 1) + if (tid > MVPP2_PRS_TCAM_SRAM_SIZE - 1) return -EINVAL; memset(pe, 0, sizeof(*pe));