From: Matt Arsenault <Matthew.Arsenault@amd.com>
Date: Sat, 4 Jan 2020 16:51:50 +0000 (-0500)
Subject: AMDGPU/GlobalISel: Set insert point after waterfall loop
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3d8f1b2d22be79aab3d246fa5bc9c24b911b0bd2;p=platform%2Fupstream%2Fllvm.git

AMDGPU/GlobalISel: Set insert point after waterfall loop

The current users of the waterfall loop utility functions do not make
use of the restored original insert point. The insertion is either
done, or they set the insert point somewhere else. A future change
will want to insert instructions after the waterfall loop, but
figuring out the point after the loop is more difficult than ensuring
the insert point is there after the loop.
---

diff --git a/llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp b/llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
index da94099..1bb01dc 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
@@ -1021,8 +1021,9 @@ bool AMDGPURegisterBankInfo::executeInWaterfallLoop(
     .addDef(ExecReg)
     .addReg(SaveExecReg);
 
-  // Restore the insert point before the original instruction.
-  B.setInsertPt(MBB, MBB.end());
+  // Set the insert point after the original instruction, so any new
+  // instructions will be in the remainder.
+  B.setInsertPt(*RemainderBB, RemainderBB->begin());
 
   return true;
 }