From: Kuniyuki Iwashima Date: Mon, 18 Jul 2022 17:26:43 +0000 (-0700) Subject: udp: Fix a data-race around sysctl_udp_l3mdev_accept. X-Git-Tag: v6.1-rc5~858^2~3^2~10 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3d72bb4188c708bb16758c60822fc4dda7a95174;p=platform%2Fkernel%2Flinux-starfive.git udp: Fix a data-race around sysctl_udp_l3mdev_accept. While reading sysctl_udp_l3mdev_accept, it can be changed concurrently. Thus, we need to add READ_ONCE() to its reader. Fixes: 63a6fff353d0 ("net: Avoid receiving packets with an l3mdev on unbound UDP sockets") Signed-off-by: Kuniyuki Iwashima Signed-off-by: David S. Miller --- diff --git a/include/net/udp.h b/include/net/udp.h index bb4c227..8dd4aa1 100644 --- a/include/net/udp.h +++ b/include/net/udp.h @@ -238,7 +238,7 @@ static inline bool udp_sk_bound_dev_eq(struct net *net, int bound_dev_if, int dif, int sdif) { #if IS_ENABLED(CONFIG_NET_L3_MASTER_DEV) - return inet_bound_dev_eq(!!net->ipv4.sysctl_udp_l3mdev_accept, + return inet_bound_dev_eq(!!READ_ONCE(net->ipv4.sysctl_udp_l3mdev_accept), bound_dev_if, dif, sdif); #else return inet_bound_dev_eq(true, bound_dev_if, dif, sdif);