From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 17 Jan 2019 03:14:54 +0000 (+0000)
Subject: i2c: imx: Fix inconsistent IS_ERR and PTR_ERR in i2c_imx_dma_request()
X-Git-Tag: v5.15~6849^2~55
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3d5b38684951564d07e3f4bb482ef9491f49ced1;p=platform%2Fkernel%2Flinux-starfive.git

i2c: imx: Fix inconsistent IS_ERR and PTR_ERR in i2c_imx_dma_request()

Change the call to PTR_ERR to access the value just tested by IS_ERR.

Fixes: 5b3a23a3cc94 ("i2c: imx: notify about real errors on dma i2c_imx_dma_request")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Esben Haabendal <esben@haabendal.dk>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---

diff --git a/drivers/i2c/busses/i2c-imx.c b/drivers/i2c/busses/i2c-imx.c
index 09b1245..42fed40 100644
--- a/drivers/i2c/busses/i2c-imx.c
+++ b/drivers/i2c/busses/i2c-imx.c
@@ -287,7 +287,7 @@ static int i2c_imx_dma_request(struct imx_i2c_struct *i2c_imx,
 
 	dma->chan_tx = dma_request_chan(dev, "tx");
 	if (IS_ERR(dma->chan_tx)) {
-		ret = PTR_ERR(dma->chan_rx);
+		ret = PTR_ERR(dma->chan_tx);
 		if (ret != -ENODEV && ret != -EPROBE_DEFER)
 			dev_err(dev, "can't request DMA tx channel (%d)\n", ret);
 		goto fail_al;