From: Vladislav Smenyuk Date: Wed, 26 Mar 2014 14:56:41 +0000 (-0700) Subject: APPLINK-6387 Core sends OnAppRegistered notification to HMI without check whether... X-Git-Tag: 3.5~199 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3d354ddec9e6233087363c1b2d000f23f08a82a7;p=profile%2Fivi%2Fsmartdevicelink.git APPLINK-6387 Core sends OnAppRegistered notification to HMI without check whether connection is established. Signed-off-by: Justin Dickow Conflicts: src/components/application_manager/src/application_manager_impl.cc --- diff --git a/src/components/application_manager/include/application_manager/application_manager_impl.h b/src/components/application_manager/include/application_manager/application_manager_impl.h index 2c688f0..a1f553c 100644 --- a/src/components/application_manager/include/application_manager/application_manager_impl.h +++ b/src/components/application_manager/include/application_manager/application_manager_impl.h @@ -464,6 +464,11 @@ class ApplicationManagerImpl : public ApplicationManager, const std::string& save_path, const uint32_t offset = 0); + /* + * @brief returns true if HMI is cooperating + */ + bool IsHMICooperating() const; + private: ApplicationManagerImpl(); bool InitThread(threads::Thread* thread); diff --git a/src/components/application_manager/src/application_manager_impl.cc b/src/components/application_manager/src/application_manager_impl.cc index 57b9a25..e6be407 100644 --- a/src/components/application_manager/src/application_manager_impl.cc +++ b/src/components/application_manager/src/application_manager_impl.cc @@ -1668,4 +1668,8 @@ mobile_apis::Result::eType ApplicationManagerImpl::SaveBinary( return mobile_apis::Result::SUCCESS; } +bool ApplicationManagerImpl::IsHMICooperating() const { + return hmi_cooperating_; +} + } // namespace application_manager diff --git a/src/components/application_manager/src/commands/mobile/register_app_interface_request.cc b/src/components/application_manager/src/commands/mobile/register_app_interface_request.cc index e838e53..1eff740 100644 --- a/src/components/application_manager/src/commands/mobile/register_app_interface_request.cc +++ b/src/components/application_manager/src/commands/mobile/register_app_interface_request.cc @@ -62,10 +62,8 @@ bool RegisterAppInterfaceRequest::Init() { void RegisterAppInterfaceRequest::Run() { LOG4CXX_INFO(logger_, "RegisterAppInterfaceRequest::Run "<< connection_key()); - // wait till all HMI capabilities initialized - const HMICapabilities& hmi_capabilities = - ApplicationManagerImpl::instance()->hmi_capabilities(); - while (!hmi_capabilities.is_hmi_capabilities_initialized()) { + // wait till HMI started + while (!ApplicationManagerImpl::instance()->IsHMICooperating()) { sleep(1); // TODO(DK): timer_->StartWait(1); ApplicationManagerImpl::instance()->updateRequestTimeout(connection_key(),