From: Alexander Aring Date: Sun, 21 Feb 2021 17:43:19 +0000 (-0500) Subject: net: ieee802154: fix nl802154 del llsec dev X-Git-Tag: accepted/tizen/unified/20230118.172025~7507^2~12^2~18 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=3d1eac2f45585690d942cf47fd7fbd04093ebd1b;p=platform%2Fkernel%2Flinux-rpi.git net: ieee802154: fix nl802154 del llsec dev This patch fixes a nullpointer dereference if NL802154_ATTR_SEC_DEVICE is not set by the user. If this is the case nl802154 will return -EINVAL. Reported-by: syzbot+d946223c2e751d136c94@syzkaller.appspotmail.com Signed-off-by: Alexander Aring Link: https://lore.kernel.org/r/20210221174321.14210-2-aahringo@redhat.com Signed-off-by: Stefan Schmidt --- diff --git a/net/ieee802154/nl802154.c b/net/ieee802154/nl802154.c index f4a4d4a..460e538 100644 --- a/net/ieee802154/nl802154.c +++ b/net/ieee802154/nl802154.c @@ -1758,7 +1758,8 @@ static int nl802154_del_llsec_dev(struct sk_buff *skb, struct genl_info *info) struct nlattr *attrs[NL802154_DEV_ATTR_MAX + 1]; __le64 extended_addr; - if (nla_parse_nested_deprecated(attrs, NL802154_DEV_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_DEVICE], nl802154_dev_policy, info->extack)) + if (!info->attrs[NL802154_ATTR_SEC_DEVICE] || + nla_parse_nested_deprecated(attrs, NL802154_DEV_ATTR_MAX, info->attrs[NL802154_ATTR_SEC_DEVICE], nl802154_dev_policy, info->extack)) return -EINVAL; if (!attrs[NL802154_DEV_ATTR_EXTENDED_ADDR])